Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If items inside token is distinct of 2 show display name #28

Conversation

xurxodev
Copy link

📌 References

⚙️ branches

app:
Origin: fix/with_correct_uid_in_pattern_and_worng_num_props_show_display_nam Target: develop-uio
dhis2-android-SDK:
Origin: develop-uio
dhis2-rule-engine:
Origin: android_2.0.1

🎩 What is the goal?

The goal is to unify prop part in the pattern, and if the pattern contains more of a property after DE uid then show the display name.

📝 How is it being implemented?

  • I have modified the logic to select the property to show

💥 How can it be tested?

Use case 1: - Configure the attribute {{UID}} in a program stage and display name should be shown as the title of the events for this program stage.
Use case 2: - Configure the attribute {{UID.name}} in a program stage and name should be shown as the title of the events for this program stage.
Use case 3: - Configure the attribute {{UID.code}} in a program stage and code should be shown as the title of the events for this program stage.
Use case 4: - Configure the attribute with error {{UID.code.name}} in a program stage and display name should be shown as the title of the events for this program stage ignoring the property.

💾 Requires DB migration?

  • Nope, we can just merge this branch.
  • Yes, but we need to apply it before merging this branch.
  • Yes, it's already applied.

🎨 UI changes?

  • Nope, the UI remains as beautiful as it was before!
  • Yeap, here you have some screenshots-

Copy link
Member

@ifoche ifoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @xurxodev

@ifoche ifoche merged commit 85798f7 into develop-uio Aug 19, 2020
@ifoche ifoche deleted the fix/with_correct_uid_in_pattern_and_worng_num_props_show_display_name branch August 19, 2020 10:58
xurxodev pushed a commit that referenced this pull request Jun 27, 2023
* Remove visibility implementation

* Implement Visibility

* Importing Data from old branch 5038

* Adding colors

* Setting methods to make button visible and disabled

* Aligning the code

* Update paperwork.json

* Check text in button and animation exit

* Update HomeScreen.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants